✨ Let solve_dependencies re-raise the RuntimeError when a generator didn't yield anything
#13264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit 9d6d765 at: https://bdb75a41.fastapitiangolo.pages.dev Modified Pages |
|
This resolves #13238, by making the raised exception more informative, and by adding an example of a badly-behaving async dependency to the docs. |
Jaza
force-pushed
the
solve-dependencies-generator-didnt-yield
branch
from
9d6d765 to
99426b4
Compare
If an async generator dependency raises RuntimeError: generator didn't yield, make solve_dependencies catch and re-raise it, to more easily identify the dependency responsible for the error, and to provide more information on how to fix the dependency
Jaza
force-pushed
the
solve-dependencies-generator-didnt-yield
branch
from
99426b4 to
efe0e06
Compare
|
📝 Docs preview for commit efe0e06 at: https://113b4278.fastapitiangolo.pages.dev Modified Pages |
svlandeg
changed the title
solve_dependencies re-raise the RuntimeError when a generator didn't yield anything
YuriiMotov
reviewed
Oct 2, 2025
There was a problem hiding this comment.
@Jaza, thanks for your interest!
I think adding a clear error message is a good idea.
As for updating docs - I think we don't need these code examples. Everything should be clear in current version.
We can just add tests for sync and async dependencies to make sure it works
| try: | ||
| solved = await stack.enter_async_context(cm) | ||
| except RuntimeError as ex: | ||
| if "generator didn't yield" not in f"{ex}": |
There was a problem hiding this comment.
Suggested change
| if "generator didn't yield" not in f"{ex}": | |
| if str(ex) == "generator didn't yield": |
This should be faster
Comment on lines
+571
to
+573
| "this is a dependency with yield that has a block with a bare except, or a " | ||
| "block with except Exception, and is not raising the exception again. Read " | ||
| "more about it in the docs: " |
There was a problem hiding this comment.
Suggested change
| "this is a dependency with yield that has a block with a bare except, or a " | |
| "block with except Exception, and is not raising the exception again. Read " | |
| "more about it in the docs: " | |
| "this is a dependency with yield that catches an exception using except, " | |
| "but doesn't raise the exception again. Read more about it in the docs: " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an async generator dependency raises
RuntimeError: generator didn't yield, makesolve_dependenciescatch and re-raise it, to more easily identify the dependency responsible for the error, and to provide more information on how to fix the dependency.