Skip to content

🔨 Update translations script #13968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

🔨 Update translations script #13968

wants to merge 4 commits into from

Conversation

YuriiMotov
Copy link
Contributor

@YuriiMotov YuriiMotov commented Aug 4, 2025 •
edited
Loading

  • Add the examples of how to handle code blocks to preserve the content from being translated
  • Add explicit encoding
  • Add instructions to generate fixed anchors for headers (tmp, needs more testing)

YuriiMotov and others added 2 commits August 4, 2025 18:00
@YuriiMotov
Add examples of handling code blocks to avoid translating them
2b6fee8
@nilslindemann @YuriiMotov
Add explicit encoding info
4c590c1 
Otherwise it raises on my Windows, as it tries to use the system encoding, which is not utf-8.
nilslindemann
nilslindemann approved these changes Aug 4, 2025
View reviewed changes
Copy link

@nilslindemann nilslindemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Aug 5, 2025
@nilslindemann
Apply Yuriis changes in the general prompt (fastapi#13968)
b0d4d2c 
see fastapi@da9659b

This adds anchors to headings, so that links with hashes stay in the translation.
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Aug 5, 2025
@nilslindemann
Formulate a rule more precise for the AI
03f05a9 
Before, it sometimes still wrapped the translation with "```markdown" and "```". Now not anymore.

Yurii, If you agree with that change, please apply to fastapi#13968 (update-translations-prompt)
@nilslindemann
Copy link

Hi Yurii, good addition! I tested with the recent German translations and it works great! See here (the commits from Aug 5).

@nilslindemann nilslindemann mentioned this pull request Aug 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslindemann nilslindemann nilslindemann approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuriiMotov @nilslindemann