Skip to content

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Oct 6, 2025

Ensure that _expression_select_gen.py works properly and provides the right type hints for code that calls select() with 3 or 4 arguments.

Note that I already provided some code to call select with 5 arguments as well. This works and runs, but won't succeed on a mypy check, as reported before.

While I think this PR is useful on its own, it's also in preparation of #1560.

@svlandeg svlandeg marked this pull request as ready for review October 6, 2025 16:09
@svlandeg svlandeg self-assigned this Oct 8, 2025
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's get this in, thank you! 🚀

@tiangolo tiangolo merged commit 35a652e into fastapi:main Oct 8, 2025
27 checks passed
@svlandeg svlandeg deleted the feature/mypy_select branch October 8, 2025 11:13
@svlandeg svlandeg removed their assignment Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants