🐛 Fix attribute handling in model_dump for compatibility with the latest Pydantic versions
#1595
Conversation
…. v2.10 + The else block added to fix linting errors (4b5ad42) for fastapi#1340 was obliterating the 'context' and 'serialize_as_any' attributes for versions >= 2.7 and < 2.11. + Fix by initializing extra_kwargs and then setting on a per-version level
+ match the upstream interface to avoid mypy linting warning. + pydantic added exclude_computed_fields in pydantic/pydantic-core#1780
There was a problem hiding this comment.
This is great, thanks so much @spazm !
It looks like your PR addresses 3 issues, 2 of which are specifically caused by mypy errors on the latest Pydantic release. These 2 are urgent to fix, and I would like to split them into a separate PR so it's easier to review and merge.
The other fix you mentioned about handling model_dump will definitely be looked at as well, but let's focus on getting the CI running first.
Please let me know if you have time to split this into a separate PR right now, otherwise I can do it.
|
Or @YuriiMotov: I would go ahead and reopen #1591 to handle the |
I think we should go with this PR. In my PR I didn't handle older Pydantic versions properly, so it would fail. |
Ok, if you feel that we should merge this as one atomic PR that's fine as well, then let's get it ready for Tiangolo to merge so we can fix the CI ASAP 🙂 |
svlandeg
changed the title
model_dump
There was a problem hiding this comment.
Nice, thank you! 🙌
And thanks @svlandeg and @YuriiMotov for the help 🚀
tiangolo
changed the title
model_dumpmodel_dump for compatibility with the latest Pydantic versions
elseblock added to fix linting errors (4b5ad42) for 💚 Fix linting in CI #1340 was obliterating the'context'and'serialize_as_any'attributes for versions >= 2.7 and < 2.11.extra_kwargsand then setting on a per-version level@finalFieldInfoexclude_computed_fieldsfrom pydantic 2.12exclude_computed_fieldsserialization option pydantic/pydantic-core#1780