Skip to content

♻ Refactor internal imports to reduce redundancy #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2022
Merged

♻ Refactor internal imports to reduce redundancy #272

merged 2 commits into from
Aug 27, 2022

Conversation

aminalaee
Copy link
Contributor

There's a redundant import which can be fixed with either of these:

from sqlalchemy import CHAR, types

Or:

from sqlalchemy.types import CHAR, TypeDecorator

@tiangolo tiangolo changed the title Update imports in sqltypes.py ♻ Refactor internal imports to reduce redundancy Aug 27, 2022
@tiangolo
Copy link
Member

Cool, thanks @aminalaee! 🍰

@tiangolo tiangolo enabled auto-merge (squash) August 27, 2022 23:49
@tiangolo tiangolo merged commit 92f52a3 into fastapi:main Aug 27, 2022
@aminalaee aminalaee deleted the patch-1 branch August 28, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @tiangolo