🐛 Fix type annotations for Model.parse_obj(), and Model.validate()
#321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix SQLModel.parse_obj, SQLModel.validate method return type "SQLModel" -> _TSQLModel [issues link](fastapi#317)
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 185 185
Lines 6134 6134
=======================================
Hits 5993 5993
Misses 141 141
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
📝 Docs preview for commit e9f1346 at: https://630aa6b97ca5615488983fb5--sqlmodel.netlify.app |
tiangolo
changed the title
Model.parse_obj(), and Model.validate()
|
Good catch, thank you @phi-friday! 🍰 This will be available in the next release, SQLModel |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix SQLModel.parse_obj, SQLModel.validate method return type
"SQLModel" -> _TSQLModel
issues link