✏ Fix typos in docs/tutorial/index.md and docs/databases.md
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmdbalkhi
approved these changes
Aug 25, 2021
|
Didn't want to create a full PR for just this, but there's another typo that you might be able to include Under "The SQLModel Advantage" in simple-hero-api (emphasis mine) "Here's where having our SQLModel class models be both SQLAlchemy models and Pydantic models at the same tieme shine." |
|
Yeah, I found a bunch of other typos throughout the docs. Maybe I should close this PR and create a new one to include the other fixes? |
prrao87
added a commit
to prrao87/sqlmodel
that referenced
this pull request
Aug 26, 2021
This was referenced Aug 26, 2021
tiangolo
changed the title
docs/tutorial/index.md
tiangolo
changed the title
docs/tutorial/index.mddocs/tutorial/index.md and docs/databases.md
|
Awesome, thanks @sebastianmarines! 🚀 🍰 |
synodriver
pushed a commit
to synodriver/sqlmodel
that referenced
this pull request
Jun 24, 2022
feat: async session typing fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in the tutorial introduction.