Release: v2.50.0 #1897

CarterLi · 2025-08-14T03:05:04Z

No description provided.

Also make keys case-sensitive

…descriptive explanations for allowed values

Moves module option structs out of global config and removes dynamic allocation, using static buffers and size assertions for safer, simpler management. Refactors module initialization and destruction to work with isolated option structs, eliminating the need for the previous modules container and related code. Unifies module option header usage and updates detection logic to leverage statically-sized option buffers, improving encapsulation and maintainability. Simplifies module function signatures and reduces coupling between modules and config. Enhances future extensibility and reliability by enforcing max size constraints and removing unnecessary indirections.

Fix #1887

This reverts commit 7ee0e87.

See https://brew.sh

Fixes: #1893

… used

Unifies unset double handling using `-DBL_MAX` sentinel Fixes #1894

Copilot

Pull Request Overview

This pull request refactors the module system architecture by removing the FFModuleBaseInfo moduleInfo field from module option structures and making module info externally accessible. This architectural change reduces memory usage and improves modularity.

Key changes include:

Removed moduleInfo field from all module option structures
Made module info globally accessible via extern declarations
Added size assertions to ensure option structures fit within maximum allowed size
Updated module initialization to use external module info references

Reviewed Changes

Copilot reviewed 300 out of 363 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/modules/swap/option.h	Removed moduleInfo field and added size assertion
src/modules/sound/sound.h	Added extern declaration for module info
src/modules/sound/sound.c	Refactored module info to be external and updated parsing
src/modules/sound/option.h	Removed moduleInfo field and added size assertion
src/modules/shell/shell.h	Added extern declaration for module info
src/modules/shell/shell.c	Refactored module info to be external and updated parsing
src/modules/shell/option.h	Removed moduleInfo field and added size assertion
src/modules/separator/separator.h	Added extern declaration for module info
src/modules/separator/separator.c	Refactored module info and fixed hardcoded TODO comment
src/modules/separator/option.h	Removed moduleInfo field and added size assertion
src/modules/publicip/publicip.h	Added extern declaration and fixed naming inconsistency
src/modules/publicip/publicip.c	Refactored module info to be external and updated parsing
src/modules/publicip/option.h	Fixed struct naming and removed moduleInfo field

Comments suppressed due to low confidence (3)

src/modules/physicaldisk/physicaldisk.c:95

The condition dev->temperature == dev->temperature is always true and doesn't check for FF_PHYSICALDISK_TEMP_UNSET. This should be dev->temperature != FF_PHYSICALDISK_TEMP_UNSET.

            if (dev->temperature != FF_PHYSICALDISK_TEMP_UNSET)

src/modules/gpu/gpu.c:49

The condition gpu->temperature == gpu->temperature is always true and doesn't check for FF_GPU_TEMP_UNSET. This should be gpu->temperature != FF_GPU_TEMP_UNSET.

        if(gpu->temperature != FF_GPU_TEMP_UNSET)

src/modules/gpu/gpu.c:129

The condition gpu->coreUsage == gpu->coreUsage is always true and doesn't check for FF_GPU_CORE_USAGE_UNSET. This should be gpu->coreUsage != FF_GPU_CORE_USAGE_UNSET.

        if (gpu->coreUsage != FF_GPU_CORE_USAGE_UNSET)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

Copilot · 2025-08-14T03:06:01Z

src/modules/netio/netio.c

+
+    ffStrbufInit(&options->namePrefix);
+    options->defaultRouteOnly =
+        #if __ANDROID__


The conditional compilation directive was changed from #if __ANDROID__ || __OpenBSD__ to just #if __ANDROID__, removing the OpenBSD condition. This change in behavior should be verified as intentional.

Suggested change

#if __ANDROID__

#if defined(__ANDROID__) || defined(__OpenBSD__)

Copilot · 2025-08-14T03:06:02Z

src/modules/os/os.c

            ""
        #elif __OpenBSD__
            ""
+        #elif __Haiku__


[nitpick] Adding a new platform condition for Haiku without a corresponding icon assignment (empty string). Consider adding an appropriate icon for consistency.

Copilot · 2025-08-14T03:06:02Z

src/modules/separator/separator.c

        setlocale(LC_CTYPE, "");
        mbstate_t state = {};
-        bool fqdn = instance.config.modules.title.fqdn;
+        bool fqdn = true; // TODO: Make this configurable


[nitpick] The hardcoded value true with a TODO comment suggests this should be made configurable. Consider addressing this technical debt or creating a tracking issue.

Suggested change

bool fqdn = true; // TODO: Make this configurable

bool fqdn = options->fqdn; // Now configurable via FFSeparatorOptions; ensure struct is updated accordingly

CarterLi and others added 30 commits July 31, 2025 14:34

Packaging: update debian stuff [ci skip]

e093c8a

Changelog: fix typo [ci skip]

559905d

Chore: remove sensitive data [ci skip]

78fb55c

Wifi (macOS): disable using of ipconfig on 15.6 too

671b111

Ref: #1874

Bar: add configurable elapsed bar borders for percent bars

afe2c85

Fix #1875

Bar: add customizable bar color options for percentage bars

c6675f8

Bar: refactor config to use nested objects and deprecates old fields

54c5bc5

Doc: update changelog [ci skip]

4f8d8de

Option: fix a possible null reference segfault

ba3e26f

Presets: add new config; fix old config

fb267ac

Doc: update changelog; fix typo

6d86813

JsonConfig: refactor string buffer JSON handling for robustness

3cef51e

JsonConfig: refactor JSON key handling to improve safety and consistency

0b02543

Also make keys case-sensitive

Percent: silense compiler warnings

59289be

Disk: add missing JSON config options

4a141c3

Display: allow "compactType": null; improve json schema

980e552

JsonSchema: small improvements

22bfaf3

Modules: remove all parseCommandOptions and related stuff

094d736

Display: add compactMode: null; improve json schema

c491c9e

GPU: support "hideType": null

dd4f006

JsonSchema: Improves JSON schema enums with oneOf objects containing …

badae2b

…descriptive explanations for allowed values

OS (Linux): don't detect Bedrock linux when ran restricted

9b68674

Fix #1881

Disk (Linux): ignore Bedrock Linux subvolumes

582268f

Ref: #1881 (comment)

Modules: add init and destroy option callbacks to module info

6f8d276

Modules: export module info

5590828

Doc: remove command line flags of modules

e753d4d

JsonConfig: write all flags when generating config file

fa4e11c

JsonConfig: make all non-module keys case-sensitive

e32987c

Chore: fix building on Windows

655d11c

CarterLi and others added 23 commits August 11, 2025 09:58

Doc: don't recommand Ubuntu PPA [ci skip]

5ab51c0

JsonSchema: remove unused properties [ci skip]

1c8e2e3

Percent: fix a copy-paste error

3345c1e

Presets: add an example

060b692

Fix #1887

CommandLine: add --gen-config-full

1469810

CI (Haiku): reduce errors when installing deps (hopefully)

883923d

Revert "CPU (macOS): use CPUID for freq detection on Intel"

7f1063d

This reverts commit 7ee0e87.

OS (Linux): tidy

1ec69d6

Doc: update README & Changelog

3276949

README: HomeBrew -> Homebrew (#1891) [ci skip]

3ef8483

See https://brew.sh

CI: upgrade to actions/checkout@v5

a0265c3

Packages: unifies Nix package detection code

4004501

Fixes: #1893

Logo (Builtin): add ObsidianOS (#1890)

ebc60ac

Cursor (macOS): improves color detection and rounding for cursor info

e1c4365

Doc: update changelog [ci skip]

53ecf57

GPU (Windows): ignore software adapters; add verbose logs

0b37ace

GPU (macOS): don't set platformApi to Metal when Metal API is not…

7446828

… used

Global: fixes -ffast-math compatibility

61f2823

Unifies unset double handling using `-DBL_MAX` sentinel Fixes #1894

Release: v2.50.0

78530b4

Doc: update changelog [ci skip]

5d8edc0

Chore: removes undocumented flag --load-config

9ebff9f

Fastfetch: adds support for reading JSON config from stdin

d477321

Doc: update changelog

e80bb48

CarterLi requested a review from Copilot August 14, 2025 03:05

Copilot AI reviewed Aug 14, 2025

View reviewed changes

CarterLi added 4 commits August 14, 2025 13:30

Separator: honors FQDN settings in Title module

0fe3db4

Flashfetch: disable decimal digits in Disk module

bd5b385

Doc: update changelog

bc37031

Doc: update changelog [ci skip]

4092115

CarterLi merged commit a99b6d6 into master Aug 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Release: v2.50.0 #1897

Release: v2.50.0 #1897

Uh oh!

CarterLi commented Aug 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Uh oh!

	#if __ANDROID__
	#if defined(__ANDROID__) \|\| defined(__OpenBSD__)

	bool fqdn = true; // TODO: Make this configurable
	bool fqdn = options->fqdn; // Now configurable via FFSeparatorOptions; ensure struct is updated accordingly

Uh oh!

Release: v2.50.0 #1897

Release: v2.50.0 #1897

Uh oh!

Conversation

CarterLi commented Aug 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!