Warns maybe-uninitialized on g++-6

[biojppm]

A quick one:

$ cmake -DCMAKE_CXX_COMPILER=g++-6 ..

causes this:

In file included from /opt/jpmag/proj/extern/fast_float/include/fast_float/ascii_number.h:9:0,
                 from /opt/jpmag/proj/extern/fast_float/include/fast_float/parse_number.h:3,
                 from /opt/jpmag/proj/extern/fast_float/include/fast_float/fast_float.h:44,
                 from /opt/jpmag/proj/extern/fast_float/tests/random_string.cpp:1:
/opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h: In function ‘fast_float::adjusted_mantissa fast_float::parse_long_mantissa(const char*, const char*) [with binary = fast_float::binary_format<double>]’:
/opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h:134:35: error: ‘answer.fast_float::adjusted_mantissa::mantissa’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     return mantissa == o.mantissa && power2 == o.power2;
            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
In file included from /opt/jpmag/proj/extern/fast_float/include/fast_float/parse_number.h:4:0,
                 from /opt/jpmag/proj/extern/fast_float/include/fast_float/fast_float.h:44,
                 from /opt/jpmag/proj/extern/fast_float/tests/random_string.cpp:1:
/opt/jpmag/proj/extern/fast_float/include/fast_float/decimal_to_binary.h:73:21: note: ‘answer.fast_float::adjusted_mantissa::mantissa’ was declared here
   adjusted_mantissa answer;
                     ^~~~~~
make[1]: *** [CMakeFiles/Makefile2:216: tests/CMakeFiles/long_exhaustive32_64.dir/all] Error 2

[biojppm]

There is also this:

opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h: In constructor ‘fast_float::decimal::decimal()’:
/opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h:144:3: error: ‘fast_float::decimal::num_digits’ should be initialized in the member initialization list [-Werror=effc++]
   decimal() = default;
   ^~~~~~~
/opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h:144:3: error: ‘fast_float::decimal::decimal_point’ should be initialized in the member initialization list [-Werror=effc++]
/opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h:144:3: error: ‘fast_float::decimal::negative’ should be initialized in the member initialization list [-Werror=effc++]
/opt/jpmag/proj/extern/fast_float/include/fast_float/float_common.h:144:3: error: ‘fast_float::decimal::truncated’ should be initialized in the member initialization list [-Werror=effc++]
In file included from /opt/jpmag/proj/extern/fast_float/include/fast_float/parse_number.h:3:0,
                 from /opt/jpmag/proj/extern/fast_float/include/fast_float/fast_float.h:44,
                 from /opt/jpmag/proj/extern/fast_float/tests/long_exhaustive32_64.cpp:1:
/opt/jpmag/proj/extern/fast_float/include/fast_float/ascii_number.h: In function ‘fast_float::decimal fast_float::parse_decimal(const char*, const char*)’:
/opt/jpmag/proj/extern/fast_float/include/fast_float/ascii_number.h:169:11: note: synthesized method ‘fast_float::decimal::decimal()’ first required here 
   decimal answer;
           ^~~~~~

[lemire]

Closed by PR from the submitter.