Added missing FASTFLOAT_ALLOWS_LEADING_PLUS ifdef check in parse_infnan #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecosta90
added a commit
to filipecosta90/redis
that referenced
this pull request
Mar 7, 2023
This was referenced Mar 7, 2023
|
I'll merge and release. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was detected via https://github.com/redis/redis/actions/runs/4349106283/jobs/7598380101 , specifically the part of
zadd ztmp +inf xThe error is related to the +inf parsing. After checking parse_infnan we can indeed confirm that the '+' sign is not being checked and the str position is updated accordingly. This PR addresses it.