Allow empty schemas as properties. #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows covering opaque types.
delvedor
reviewed
Jul 22, 2018
index.js
Outdated
| else json+= null | ||
| ` | ||
| } else throw new Error(`${schema} unsupported`) | ||
| } else { |
There was a problem hiding this comment.
Probably just to be safe we can add a check here to verify that you are passing an empty schema.
function isEmpty (schema) {
for (var key in schema) {
if (schema.hasOwnProperty(key)) return false
}
return true
}Could be enough :)
|
Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows covering opaque types.
I am using this together with a GraphQL endpoint which has custom scalars. These scalars are opaque from the type system so a JSON schema cannot be derived.