Skip to content

Revert "Replaced asString with JSON.stringify" #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2017

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jan 6, 2017

This reverts commit 1a63b7c.

Fixes #17

@delvedor
Copy link
Member

delvedor commented Jan 7, 2017

New bench:

JSON.stringify array x 3,575 ops/sec ±3.36% (85 runs sampled)
fast-json-stringify array x 2,806 ops/sec ±0.87% (94 runs sampled)

JSON.stringify long string x 13,917 ops/sec ±0.68% (90 runs sampled)
fast-json-stringify long string x 14,005 ops/sec ±0.72% (94 runs sampled)

JSON.stringify short string x 5,237,933 ops/sec ±0.76% (89 runs sampled)
fast-json-stringify short string x 11,878,885 ops/sec ±0.62% (91 runs sampled)

JSON.stringify obj x 1,862,224 ops/sec ±0.84% (94 runs sampled)
fast-json-stringify obj x 2,795,518 ops/sec ±0.67% (94 runs sampled)

LGTM.

@delvedor delvedor merged commit e4ea125 into master Jan 7, 2017
@delvedor delvedor deleted the restore-obj-speed branch January 7, 2017 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants