Fix: Support for empty schemas in additionalProperties #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve issue #293. It carries out additional
type === undefined
checks on theadditionalProperties: {}
code path resolving to$asAny
in these cases. This enables support for emptyadditionalProperties: {}
schemas.Notes
The check on line 543 was all that was necessary to resolve this issue. The preceding check on line 445 was added as
$asAny
seemed appropriate (both code paths are virtually identical), however I've not implemented any specific tests for this code path as I'm not certain what conditions trigger it. Feel free to remove if necessary.Benchmark
Checklist
npm run test
andnpm run benchmark
and the Code of conduct