support for recursion in arrays #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Oct 18, 2021
index.js
Outdated
| return code | ||
| } | ||
|
|
||
| const functionsWithReferenceCode = new Map() |
There was a problem hiding this comment.
This map must be cleared after each code generation, otherwise we will leak memory.
There was a problem hiding this comment.
for sure, yes, my bad. Will fix that
Eomm
reviewed
Oct 18, 2021
| } | ||
| }, | ||
| type: 'array', | ||
| items: { $ref: '#/definitions/directory' } |
There was a problem hiding this comment.
Could you add a test using external schemas?
I think a map track only one ref when there are conflicts
There was a problem hiding this comment.
Good catch! Fixed issue with conflicts and added corresponding tests
mcollina
reviewed
Oct 18, 2021
Eomm
reviewed
Oct 18, 2021
Eomm
approved these changes
Oct 19, 2021
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handle one of the cases mentioned in this issue #181
Checklist
npm run testandnpm run benchmarkand the Code of conduct