Support inline $id references #411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
This PR should resolve inline
$id
references mentioned on issue #410. This implementation adds an additionalschemaReferenceMap
which is used to collect schemas with$id
observed during the build phase. These references are later resolved in subsequent calls to therefFinder(...)
function.Note: There is some overlap here with the existing
externalSchema
variable which I think may be trying to resolve specifically for anchor (or#
) references (I'm entirely not sure). I have left theexternalSchema
implementation as is as a fall through. It was noted however that theexternalSchema
variable wasundefined
for the inline$id
/$ref
code path.This PR also adds the
$id
property to the TS definition forBaseSchema
Submitting for community review
Benchmark
CPU: AMD Ryzen 7 3700X
RAM: 16GB
OS: Windows 10