Skip to content

fix: set 23 hour cycle #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

fix: set 23 hour cycle #427

merged 1 commit into from
May 26, 2022

Conversation

ivan-tymoshenko
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko commented May 25, 2022 •
edited
Loading

Checklist

Right now date serialization can return 24 hours. "24:12:43". I'm not sure that this is expected.

That is the reason why ci fails sometimes.

RafaelGSS
RafaelGSS approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

jsumners
jsumners approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcollina mcollina merged commit 549f1f4 into fastify:master May 26, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the fix-set-23-hour-cycle branch May 27, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivan-tymoshenko @jsumners @RafaelGSS @mcollina