Skip to content

fix: throw an error if cannot convert value to number #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2022
Merged

fix: throw an error if cannot convert value to number #433

merged 1 commit into from
May 28, 2022

Conversation

ivan-tymoshenko
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko commented May 27, 2022 •
edited
Loading

Checklist

Fixed #431

@ivan-tymoshenko
Copy link
Member Author

Снимок экрана 2022-05-27 в 17 53 58

Fdawgs
Fdawgs reviewed May 27, 2022
View reviewed changes
@ivan-tymoshenko ivan-tymoshenko force-pushed the throw-an-error-if-cannot-convert-value-to-number branch from 7a65be4 to 780e728 Compare May 27, 2022 16:11
mcollina
mcollina approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs merged commit 4bec21e into fastify:master May 28, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the throw-an-error-if-cannot-convert-value-to-number branch June 7, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore invalid number value
3 participants
@ivan-tymoshenko @mcollina @Fdawgs