Skip to content

pre-compute empty string #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

pre-compute empty string #573

merged 1 commit into from
Jan 11, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 11, 2023

well. probably v8 optimizes, maybe not. pre-computing is anyway the way to go.

Checklist

mcollina
mcollina approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 63d2070 into master Jan 11, 2023
@mcollina mcollina deleted the one-string-doublequote branch January 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ivan-tymoshenko ivan-tymoshenko Awaiting requested review from ivan-tymoshenko

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina