Edit grammar and syntax in readme #62
Conversation
There was a problem hiding this comment.
A clear part that we are missing here is that this should be combined with http://npm.im/flatstr.
README.md
Outdated
| __fast-json-stringify__ is two times faster than `JSON.stringify()`. | ||
| It is particularly suited if you are sending small JSON payloads, the | ||
| advantages reduces on large payloads. | ||
| __fast-json-stringify__ is significantly faster than `JSON.stringify()` for small payloads. Its performance advantage shrinks as your payload grows. |
There was a problem hiding this comment.
Can you explain change a bit more? Have you experience a degradation in throughput?
There was a problem hiding this comment.
I was trying to just rephrase the existing idea based on the benchmarks. The most significant change was removing "two times faster." I thought it was clearer to focus on the performance characteristics instead of using a rough average of the performance improvement that might not apply to many users.
What do you mean? |
|
See fastify/fastify#172. |
|
Gotcha, so you're suggesting that the readme should recommend using flatstr in combination with fast-json-stringify? |
|
Yes. |
|
Added |
Hey there, thanks for building this! Noticed a few sentences with awkward syntax or grammar in the readme. Went through and touched it up.