Skip to content

Conversation

ShaunLWM
Copy link
Contributor

I've been using this plugin for one of my project which requires Google login. Managed to make it work by cross referencing with values from https://github.com/jaredhanson/passport-google-oauth2.

Do take a look and see if there's anything I can do to help with this configuration.
Thank you!

Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI is red

@ShaunLWM
Copy link
Contributor Author

I'm sorry, but to be honest, I have literally no idea how this CI thing works, except that I know it does mock test. Is there anything I can do on my end to understand the error? So sorry about it.

Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the code on master fails because fastify changes its error message.
Thanks for the patience too!

@allevo allevo merged commit 0b37b04 into fastify:master Oct 28, 2018
@allevo
Copy link
Member

allevo commented Oct 28, 2018

Published! v0.2.2

@ShaunLWM
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants