Skip to content

Update readme to fix code samples #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

Update readme to fix code samples #35

merged 1 commit into from
Dec 3, 2018

Conversation

cemremengu
Copy link
Contributor

Based on #34

I think that was a "no" :)

@cemremengu
Update readme to fix code samples
28c576d 
Based on #34 

I think that was a no :)
mcollina
mcollina approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu merged commit 1655387 into master Dec 3, 2018
@cemremengu cemremengu deleted the cemremengu-patch-1 branch December 3, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cemremengu @mcollina