Bring your own node-postgres #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Feb 12, 2019
|
@mcollina we are bumping a major right? |
|
yea
Il giorno mar 12 feb 2019 alle 17:26 Cemre Mengu <notifications@github.com>
ha scritto:
… @mcollina <https://github.com/mcollina> we are bumping a major right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL4-KuNjBZZbwbZQPWMzjxZw2Zukv7ks5vMutCgaJpZM4a2jbv>
.
|
|
@MichielDeMey v2.0.0 is now on npm |
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
node-postgresas apeerDependencyforcing you to bring your own version.As a side-effect of this change, the library's version will require a major version bump since we cannot guarantee backward-compatibility for everyone.
The earliest version of
pgthat I could find that we can support is technically>=5.0.0(callingpg.nativewill returnnullin case the native library was not installed), but the tests rely onpg.Poolwhich was introduced in6.0.0, hence the safest version we can support right now is6.0.0.If we want to safely add support for
5.0.0we'll have to re-write the tests to remove dependency onpg.Pool.Fixes #42.