Skip to content

Add a GitHub Actions powered CI #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

Add a GitHub Actions powered CI #59

merged 1 commit into from
Oct 23, 2019

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Oct 23, 2019 •
edited
Loading

Hello ^^

As titled this PR adds a GitHub Actions powered CI (for now I did not remove Travis as the GitHub Actions service is still in beta):

  • There's no longer any needs to compile libpq from the sources to run the pg-native test and overall it's faster than Travis in general.
  • Adds Node.js 13.x to the CI matrix

Feel free to ping me if changes need to be made ^^

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit bcdc083 into fastify:master Oct 23, 2019
@darkgl0w darkgl0w deleted the github-actions branch October 23, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkgl0w @mcollina