Skip to content

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented May 1, 2019

Updates the dependencies to their latest available version, except for tap.

NB: Node 6 has gone EOL since yesterday, so we should remove Node 6 from the CI config and update tap to it's latest version (currently 13.1.1 -> apart from dropping Node 6 support it won't break the package and all the tests are passing without any problem).

darkgl0w added 2 commits May 1, 2019 18:40
Updated to tap@12.6.6 in order to keep node 6 compatibility
@mcollina
Copy link
Member

mcollina commented May 1, 2019

That would require bumping a major. I don’ think we should do that at this point. Would you mind adding tap to greenkeeper ignore?

@darkgl0w
Copy link
Member Author

darkgl0w commented May 1, 2019

Done. 😄

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 9b0febc into fastify:master May 2, 2019
@darkgl0w darkgl0w deleted the updated-dependencies branch May 2, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants