Skip to content

feat: support redis connection url #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2020
Merged

feat: support redis connection url #45

merged 4 commits into from
Apr 17, 2020

Conversation

SkeLLLa
Copy link
Contributor

@SkeLLLa SkeLLLa commented Apr 16, 2020 •
edited
Loading

Adds support for passing url into underlying redis constructor.

Closes #40

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Eomm
Eomm reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the package-lock and add it to the .gitignore?

Then it LGTM ✨

mcollina
mcollina approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SkeLLLa
Copy link
Contributor Author

SkeLLLa commented Apr 17, 2020

@Eomm damn, always forget to do that :), thanks. Gitignore updated.

@Eomm Eomm merged commit e15d992 into fastify:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing only a URL to the redis instance is not supported
3 participants
@SkeLLLa @mcollina @Eomm