Skip to content

Fix existing redis client example in README #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix existing redis client example in README #65

merged 1 commit into from
Nov 20, 2020

Conversation

mdboop
Copy link
Contributor

@mdboop mdboop commented Nov 20, 2020 •
edited
Loading

The existing redis client example passes a non-declared variable to the register function. I think my change is in line with other examples, but feel free to fix how you see fit. Thank you!

Checklist

mcollina
mcollina approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good spot!

@mcollina mcollina merged commit 837d0fc into fastify:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboop @mcollina