Add option to close passed in client #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Nov 20, 2020
| fastify.decorate('redis', client) | ||
| if (options.closeClient === true) { | ||
| fastify.addHook('onClose', close) | ||
| } |
There was a problem hiding this comment.
I think we would need to support when this is false in all cases.
There was a problem hiding this comment.
I'm not sure about that. The issue is around passing in a specific client and managing that outside instance.
There was a problem hiding this comment.
I mean, if somebody is not passing a client in and closeClient: false, then closing the client seems off.
There was a problem hiding this comment.
I'm unclear why they would do that or why it would even be supported. They wouldn't be able to manage it without first pulling the instance from Fastify.
mcollina
approved these changes
Nov 20, 2020
|
At your leisure. I have no permissions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #64
Checklist
npm run testandnpm run benchmarkand the Code of conduct