Skip to content

Conversation

gkampitakis
Copy link
Contributor

@gkampitakis gkampitakis commented Mar 14, 2021

Solves

As discussed on the issue #75 there is no closeClient when providing a Redis client in a namespace.

I just have a question regarding this solution, if I pass

{
  host: '127.0.0.1',
  closeClient: true
}

does this mean I am adding two onClose hooks ?

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6899a86 into fastify:master Mar 15, 2021
@gkampitakis gkampitakis deleted the closeNamedInstance branch March 15, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants