-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat: move to tap15 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/test.js
Outdated
t.beforeEach((done) => { | ||
const fastify = Fastify() | ||
t.beforeEach(() => { | ||
return new Promise((resolve) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use async/await instead
Also this does not bump the tap dependency. |
Looks like tap 15 coverage behaviour of the cli has changed. Now it defaults to 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecations must be fixed
test/test.js
Outdated
}) | ||
|
||
fastify.ready((err) => { | ||
fastify.ready(async (err) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fastify.ready(async (err) => { | |
await fastify.ready() |
test/test.js
Outdated
done() | ||
}) | ||
await fastify.redis.flushall() | ||
.then(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the .then()
test/test.js
Outdated
}) | ||
await fastify.redis.flushall() | ||
.then(() => { | ||
fastify.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fastify.close() | |
await fastify.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.