Skip to content

Conversation

zekth
Copy link
Member

@zekth zekth commented Apr 6, 2021

No description provided.

test/test.js Outdated
t.beforeEach((done) => {
const fastify = Fastify()
t.beforeEach(() => {
return new Promise((resolve) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use async/await instead

@mcollina
Copy link
Member

mcollina commented Apr 6, 2021

Also this does not bump the tap dependency.

@zekth
Copy link
Member Author

zekth commented Apr 6, 2021

Looks like tap 15 coverage behaviour of the cli has changed. Now it defaults to 100

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecations must be fixed

test/test.js Outdated
})

fastify.ready((err) => {
fastify.ready(async (err) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fastify.ready(async (err) => {
await fastify.ready()

test/test.js Outdated
done()
})
await fastify.redis.flushall()
.then(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the .then()

test/test.js Outdated
})
await fastify.redis.flushall()
.then(() => {
fastify.close()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fastify.close()
await fastify.close()

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c2001f4 into master Apr 6, 2021
@mcollina mcollina deleted the tap15 branch April 6, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants