to support ioredis. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvedor
requested changes
Nov 22, 2017
There was a problem hiding this comment.
Great job!
I'd like to maintain this backwards compatible.
We should pass all the options in the same object, as well as driver.
Then internally we should do something like the following:
const Driver = opts.driver
delete opts.driver
client = Driver ? new Driver(opts) : redis.createClient(opts)
|
Sorry, I'm new to this, now right? |
delvedor
reviewed
Nov 22, 2017
README.md
Outdated
| Add it to you project with `register` and you are done! | ||
| You can access the *Redis* client via `fastify.redis`. | ||
|
|
||
| And you can custom your own redis client, use ``driver`` option, now support [ioredis](https://github.com/luin/ioredis) client, default is [redis](https://github.com/NodeRedis/node_redis). |
delvedor
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the
optionsthat pass to theregister, thedriveroption to support ioredis, and theredisoption will be passed to the Redis client.