Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add benchmarking script, additional benchmarks #407

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

mweberxyz
Copy link
Contributor

Implements npm run benchmark and adds additional benchmarks to help catch regressions/improvements

Example usage

% npm run benchmark

> @fastify/view@8.2.0 benchmark
> node benchmark.js

express.js: 24266.67 req/s
fastify.js: 96245.34 req/s
fastify-twig.js: 86080 req/s
fastify-ejs-async.js: 104426.67 req/s
fastify-ejs-with-layout.js: 89322.67 req/s

Checklist

benchmark.js Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mweberxyz
Copy link
Contributor Author

Just pushed a light refactoring and added benchmarks for all supported engines - requesting re-review.

@mcollina mcollina merged commit d5ef69b into fastify:master Feb 18, 2024
19 checks passed
@mweberxyz mweberxyz deleted the chore/benchmark-script branch February 19, 2024 23:31
ddadaal referenced this pull request in PKUHPC/OpenSCOW Feb 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/view](https://togithub.com/fastify/point-of-view) | [`8.2.0`
->
`9.0.0`](https://renovatebot.com/diffs/npm/@fastify%2fview/8.2.0/9.0.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fview/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fview/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fview/8.2.0/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fview/8.2.0/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/point-of-view (@&#8203;fastify/view)</summary>

###
[`v9.0.0`](https://togithub.com/fastify/point-of-view/releases/tag/v9.0.0)

[Compare
Source](https://togithub.com/fastify/point-of-view/compare/v8.2.0...v9.0.0)

#### What's Changed

- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/point-of-view/pull/398](https://togithub.com/fastify/point-of-view/pull/398)
- test(eta): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/point-of-view/pull/400](https://togithub.com/fastify/point-of-view/pull/400)
- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/point-of-view/pull/401](https://togithub.com/fastify/point-of-view/pull/401)
- chore(.gitignore): add .tap/ dir by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/point-of-view/pull/403](https://togithub.com/fastify/point-of-view/pull/403)
- chore(.prettierignore): add by
[@&#8203;mweberxyz](https://togithub.com/mweberxyz) in
[https://github.com/fastify/point-of-view/pull/406](https://togithub.com/fastify/point-of-view/pull/406)
- chore: add benchmarking script, additional benchmarks by
[@&#8203;mweberxyz](https://togithub.com/mweberxyz) in
[https://github.com/fastify/point-of-view/pull/407](https://togithub.com/fastify/point-of-view/pull/407)
- build(deps-dev): bump delay from 5.0.0 to 6.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/point-of-view/pull/409](https://togithub.com/fastify/point-of-view/pull/409)
- chore(benchmark): remove `delay` dependency by
[@&#8203;mweberxyz](https://togithub.com/mweberxyz) in
[https://github.com/fastify/point-of-view/pull/410](https://togithub.com/fastify/point-of-view/pull/410)
- refactor(index): async flow control by
[@&#8203;mweberxyz](https://togithub.com/mweberxyz) in
[https://github.com/fastify/point-of-view/pull/405](https://togithub.com/fastify/point-of-view/pull/405)

#### New Contributors

- [@&#8203;mweberxyz](https://togithub.com/mweberxyz) made their first
contribution in
[https://github.com/fastify/point-of-view/pull/406](https://togithub.com/fastify/point-of-view/pull/406)

**Full Changelog**:
fastify/point-of-view@v8.2.0...v9.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on sunday" in timezone Asia/Shanghai,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/PKUHPC/SCOW).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants