Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dotfiles for editor configuration #53

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

mweberxyz
Copy link
Contributor

fastify core added these files in fastify/fastify#2269

Quoting the PR in core:

  1. Adds .eslintrc to help people using standard in vscode. See autoFixOnSave not working! standard/vscode-standard#83 (comment)
  2. Add .prettierignore to prevent prettier people from submitting difficult PRs

and .npmrc already exists here.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.eslintrc Outdated Show resolved Hide resolved
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Signed-off-by: mweberxyz <1062734+mweberxyz@users.noreply.github.com>
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the master of the order approves, then i have to approve too ;)

@Uzlopak Uzlopak merged commit 7b157b5 into fastify:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants