Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Implement editing a trigger #452

Closed
taquitos opened this issue Mar 30, 2018 · 8 comments
Closed

Implement editing a trigger #452

taquitos opened this issue Mar 30, 2018 · 8 comments
Milestone

Comments

@taquitos
Copy link
Collaborator

taquitos commented Mar 30, 2018

  • Be able to change an existing trigger
    • the time on which to run a nightly build
    • the branch to run tests for
    • NOTE: We are not implementing an ability to be able to change the trigger type
  • Messaging about manually editing json to add another if you must.
@KrauseFx KrauseFx added this to the 1.0 milestone Mar 30, 2018
@KrauseFx KrauseFx changed the title Editing a trigger Implement editing a trigger Apr 3, 2018
@KrauseFx
Copy link
Member

As described in the use case, we decided not to edit the trigger type for the time being

@nakhbari
Copy link
Contributor

nakhbari commented May 1, 2018

@KrauseFx so should we close this issue?

@taquitos
Copy link
Collaborator Author

taquitos commented May 1, 2018

@nakhbari 🌮

@taquitos taquitos closed this as completed May 1, 2018
@KrauseFx
Copy link
Member

KrauseFx commented May 2, 2018

I don't think we have a separate issue to edit the trigger "content", e.g. the time on which to run a nightly build, or the branches to run tests for. Let's keep this open for now then?

@KrauseFx KrauseFx reopened this May 2, 2018
@taquitos
Copy link
Collaborator Author

taquitos commented May 2, 2018

@KrauseFx Oh, good point. Updating the description

@nakhbari
Copy link
Contributor

nakhbari commented May 2, 2018

With our current infrastructure., if the project config is updated, are the workers updated to use the new triggers automagically?

@taquitos
Copy link
Collaborator Author

taquitos commented May 2, 2018

Good question, nope. That only happens on restart. I think the infra allows for us to kill workers and restart them, but we haven't wired up project config changes. I think the only time we start workers is on startup

@fastlane-danger-bot
Copy link
Contributor

We decided to pause our work on fastlane.ci to focus on the core fastlane product as we have a lot on the roadmap. You can find more information on the main GitHub page. This issue will be auto-closed 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants