Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cd.md #3514

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Update cd.md #3514

merged 2 commits into from
Jan 9, 2020

Conversation

serragnoli
Copy link
Contributor

Updating doc as per fastlane/fastlane#15496 (comment)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Jan 8, 2020
@legalcodes
Copy link
Contributor

legalcodes commented Jan 9, 2020

Nice catch @serragnoli , once the CLA is signed I think we're good to go.

One question: the fastlane docs recommend:

Install fastlane using

# Using RubyGems
sudo gem install fastlane -NV

Have you verified that gem install fastlane works without the flags and heightened permissions?

@serragnoli
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Jan 9, 2020
@serragnoli
Copy link
Contributor Author

Hi @legalcodes
Unfortunately I haven't tried the gem installation.
Thanks.

@legalcodes
Copy link
Contributor

@serragnoli OK, in that case I've added a link to the docs in this part. Thanks!

Co-Authored-By: Jon Tippens <legalcodes@users.noreply.github.com>
@legalcodes legalcodes merged commit 5198fab into flutter:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants