Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'zip' example from update_info_plist #10494

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Remove 'zip' example from update_info_plist #10494

merged 2 commits into from
Oct 19, 2017

Conversation

spinningarrow
Copy link
Contributor

It doesn't seem to be relevant.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

@spinningarrow
Remove 'zip' example from update_info_plist
8991c49 
It doesn't seem to be relevant.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@KrauseFx
Copy link
Member

KrauseFx commented Oct 4, 2017

Ha, nice catch, thanks 👍 Can you address the comments from the bots?

@spinningarrow
Copy link
Contributor Author

Yes, I'll get to it ASAP!

@KrauseFx
Copy link
Member

KrauseFx commented Oct 4, 2017

Thanks ❤️

@spinningarrow
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@spinningarrow
Remove trailing comma
a6cddc9 
Thanks rubocop!
@spinningarrow
Copy link
Contributor Author

'ASAP' took a while - sorry about that. Checks seem happy now 👍

@matthewellis
Copy link
Collaborator

@KrauseFx Reviewed and all seems good, are you happy to merge?

@KrauseFx KrauseFx merged commit fce23d3 into fastlane:master Oct 19, 2017
@fastlane-bot
Copy link

Hey @spinningarrow 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@ohayon ohayon mentioned this pull request Oct 23, 2017
Merged
laullon added a commit to laullon/fastlane that referenced this pull request Oct 23, 2017
@laullon
Merge branch 'master' into snapshot-record-video
eb7c264 
* master: (96 commits)
  [snapshot] Fix unused result warning in helper (fastlane#10662)
  Typo Fix (fastlane#10661)
  Version bump to 2.62.1 (fastlane#10670)
  Support manual signingStyle (fastlane#10508)
  Dont count lane switches in metrics (fastlane#10659)
  Add missing html tag (fastlane#10657)
  Deprecates add_id_info_limits_tracking in favor of add_id_info_uses_idfa (fastlane#10653)
  [fastlane core] fix unit tests when Xcode 9.0 not installed (fastlane#10655)
  Add automatic commiting of mkdocs.yml for docs generation (fastlane#10578)
  [Client] Handle Faraday::ParsingError as part of Client#with_retry logic (fastlane#10646)
  Revert "[BuildWatcher] Handle parse error while waiting for build processing (fastlane#10621)" (fastlane#10647)
  [BuildWatcher] Handle parse error while waiting for build processing (fastlane#10621)
  Remove 'zip' example from update_info_plist (fastlane#10494)
  Make plugin details optional (fastlane#10628)
  fix leaking sw_vers (fastlane#10630)
  Update snapshot instructions (fastlane#10626)
  Update update instructions of snapshot (fastlane#10627)
  Don't add unneeded new-line when asking for user input (fastlane#10629)
  Forward match keychain password into cert (fastlane#10619)
  SW_VERS should be lowercase (fastlane#10625)
  ...

# Conflicts:
#	README.md
#	cert/README.md
#	snapshot/README.md
#	snapshot/lib/assets/SnapshotHelper.swift
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.62.1 🚀

@spinningarrow spinningarrow deleted the patch-1 branch October 24, 2017 15:42
@fastlane fastlane locked and limited conversation to collaborators Dec 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewellis matthewellis matthewellis approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spinningarrow @googlebot @KrauseFx @matthewellis @fastlane-bot