Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] fix compile error on macCatalyst #19917

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

philipparndt
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #19915

Description

Added && !targetEnvironment(macCatalyst)when checking for the device orientation due to a syntax error when compiling for macCatalyst. Mac does not have a device orientation.

Tested by:

Test errors

I get some unrelated test errors when executing bundle exec rspec. I get the same errors with and without my patch.

Failures:

  1) Fastlane Fastlane::FastFile update_fastlane when no update needed
     Failure/Error: expect(UI).to receive(:success).with("Nothing to update ✅")
     
       (FastlaneCore::UI (class)).success("Nothing to update ✅")
           expected: 1 time with arguments: ("Nothing to update ✅")
           received: 0 times
     # ./fastlane/spec/actions_specs/update_fastlane_spec.rb:18:in `block (4 levels) in <top (required)>'
     # /Library/Ruby/Gems/2.6.0/gems/webmock-3.12.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

  2) Fastlane Fastlane::FastFile update_fastlane when update with RubyGems
     Failure/Error: expect(FastlaneCore::FastlaneFolder).to receive(:swift?).and_return(true)
     
       (FastlaneCore::FastlaneFolder (class)).swift?(*(any args))
           expected: 1 time with any arguments
           received: 0 times with any arguments
     # ./fastlane/spec/actions_specs/update_fastlane_spec.rb:32:in `block (4 levels) in <top (required)>'
     # /Library/Ruby/Gems/2.6.0/gems/webmock-3.12.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

  3) Fastlane Fastlane::FastFile update_fastlane when update with Homebrew
     Failure/Error: expect(Fastlane::Helper).to receive(:homebrew?).and_return(true).twice
     
       (FastlaneCore::Helper).homebrew?(*(any args))
           expected: 2 times with any arguments
           received: 0 times with any arguments
     # ./fastlane/spec/actions_specs/update_fastlane_spec.rb:69:in `block (4 levels) in <top (required)>'
     # /Library/Ruby/Gems/2.6.0/gems/webmock-3.12.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

Finished in 8 minutes 5 seconds (files took 6.18 seconds to load)
7012 examples, 3 failures

Failed examples:

rspec ./fastlane/spec/actions_specs/update_fastlane_spec.rb:13 # Fastlane Fastlane::FastFile update_fastlane when no update needed
rspec ./fastlane/spec/actions_specs/update_fastlane_spec.rb:28 # Fastlane Fastlane::FastFile update_fastlane when update with RubyGems
rspec ./fastlane/spec/actions_specs/update_fastlane_spec.rb:68 # Fastlane Fastlane::FastFile update_fastlane when update with Homebrew

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! Thanks for fixing this 😊 And thanks for also updating that version number 🙌

@joshdholtz joshdholtz changed the title fix compile error on macCatalyst [snapshot] fix compile error on macCatalyst Feb 11, 2022
@joshdholtz joshdholtz merged commit 158b249 into fastlane:master Feb 11, 2022
@fastlane-bot
Copy link

Hey @philipparndt 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.204.3 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SnapshotHelper: Cannot find 'XCUIDevice' in scope
3 participants