Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgresql enhancements #31

Closed
wants to merge 5 commits into from
Closed

Postgresql enhancements #31

wants to merge 5 commits into from

Conversation

pypingou
Copy link
Contributor

No description provided.

@pypingou
Only append a trailing slash if there are only two in the URL given
06e3fd9 
Otherwise we may end up with an URL such as:
  driver://user:pass@host:port/dbname/
which is invalid, the trailing slash should not be there.
@pypingou
Display to the user the actual error message this it is informative
fb19fe1 
The actual error message contains information such as:
- You need to provide a password
- Password was invalid
- Server is not running
- Host could not be found

These information are more helpful to debug a problem than the standard
error message in place now.
@pypingou
In cases where the url provided ends-up with the database name, we sh…
b54c64f 
…ould not update the URL

The problem occurs with URL such as:
  driver://user:pass@host:port/dbname
These are valid URLs and actually is the URL structure recommended by
SQLAlchemy. These URLs already contain the database name and thus we
should not append again the database name to them otherwise the URL
becomes invalid.
@pypingou
Do not ask for the database name if it is already in the URL provided
e8a6f91 
If the user provided an URL of type:
  driver://user:pass@host:port/dbname
Then we can extract the database name from the URL and avoid asking the
user again.
@pypingou
Copy link
Contributor Author

These changes should fix #28

@pypingou
Copy link
Contributor Author

Note: The travis failure does not seem related to my changes :-/

@pypingou pypingou mentioned this pull request Sep 2, 2014
Closed
@quantus
Copy link
Member

quantus commented Sep 27, 2014

Thanks for the PR and sorry for the long delay. I have merged this PR manually while leaving commit b54c64f out of it. That commit was not needed after I fixed incorrect configuration values in commit 8c08b65.

@quantus quantus closed this Sep 27, 2014
@pypingou
Copy link
Contributor Author

Thanks!

@pypingou pypingou deleted the psql_enhancement branch September 27, 2014 19:52
@daneoshiga daneoshiga mentioned this pull request Oct 31, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pypingou @quantus