-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Sheets Query support in sql
processor
#1472
Conversation
@Arpita-Jaiswal can you take a look at the fastn-core/src/library2022/processor/google_sheets.rs, there is a lot of stuff happening there and I want your opinion. |
@amitu I have temporarily removed the timestamp conversion for now. also, I have added a new optional processor argument named Example:
|
The sheet argument conflicts if the sheet is a column name. Should we name processor arguments as |
I agree, but it should not conflict with the column name because these words are rarely used, and this looks cleaner without '$'. However, this is just my opinion. |
It looks cleaner, but if conflict happens user will have no choice. |
Yes, although these argument names need not be the same as the column name, many users choose to name them to match the column name. Therefore, I agree that it can lead to conflicts. |
Background
We are adding support for Google Sheets
Query
to thesql
processor. You can find more information on this and participate in the relateddiscussion
.How it Works
The Google Charts API allows you to query a Google Sheet much like you would with an SQL database, though it currently only supports data retrieval queries such as "SELECT." Our primary objective is to enable users to provide the URL of their Google Sheet as the
db
parameter for thesql
processor. Currently, only public sheets are supported, but we plan to add support for private sheets in the future.Example:
Todos
sheet
Updates
sheet
anddb
instead of$sheet$
and$db$, we will deprecate these in a follow up PR and replace these with
$sheetfbt
tests for now, will do manual testing instead. will add fbt tests in a follow up PR