Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static build for linux #1668

Merged
merged 15 commits into from
Jan 2, 2024
Merged

Static build for linux #1668

merged 15 commits into from
Jan 2, 2024

Conversation

siddhantk232
Copy link
Contributor

@siddhantk232 siddhantk232 commented Jan 2, 2024 •
edited
Loading

  • remove dependency on quick-js. rquickjs is used on all platforms (mac, win, linux).
  • update to rust 1.75 in nix dev env.
  • statically linked binary for linux distributions (x86_64) built using rust-musl-builder
  • Fix dynamic builds on mac and windows
  • windows fix: add cargo config to properly detect libpq. This uses postgres 14 already installed on the GH CI windows runner. This will break if they decide to change the version or remove postgres altogether
  • Tested already on github actions on mac, windows and, linux.

@amitu amitu merged commit 5281362 into main Jan 2, 2024
1 check passed
@amitu amitu deleted the fix/static_build branch January 2, 2024 14:02
@siddhantk232 siddhantk232 mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitu amitu amitu approved these changes

@Arpita-Jaiswal Arpita-Jaiswal Awaiting requested review from Arpita-Jaiswal

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddhantk232 @amitu