Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use quick-js on non windows platforms #1670

Merged
merged 3 commits into from
Jan 3, 2024
Merged

use quick-js on non windows platforms #1670

merged 3 commits into from
Jan 3, 2024

Conversation

siddhantk232
Copy link
Contributor

Building with rquickjs for linux and mac throws errors but this lib doesn't seem to work correctly at runtime. I have reverted the changes to use rquickjs for now.

  • .dockerignore to reduce docker image size

.dockerignore to reduce docker image size
@amitu
Copy link
Contributor

amitu commented Jan 3, 2024

@siddhantk232 can you do a version bump also, I will merge, create release and test on Heroku.

@siddhantk232
Copy link
Contributor Author

@siddhantk232 can you do a version bump also, I will merge, create release and test on Heroku.

done @amitu

@amitu
Copy link
Contributor

amitu commented Jan 3, 2024

Update the Cargo.lock file as well (it happens if you run cargo check etc).

@siddhantk232
Copy link
Contributor Author

Update the Cargo.lock file as well (it happens if you run cargo check etc).

done 🙂

return default logged out details when auth feature is disabled
@siddhantk232
Copy link
Contributor Author

siddhantk232 commented Jan 3, 2024

Added a fix for the user-details processor as well. When logged out or when the auth feature is disabled, it'll give the default user details, i.e., logged out user.

@amitu

@amitu amitu merged commit c52cd13 into main Jan 3, 2024
1 check passed
@amitu amitu deleted the fix/quickjs branch January 3, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants