Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails on older Mac OSX versions #144

Closed
ambrosejcarr opened this issue Aug 14, 2020 · 5 comments
Closed

Installation fails on older Mac OSX versions #144

ambrosejcarr opened this issue Aug 14, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@ambrosejcarr
Copy link

Hello, thank you for building this tool! Our cellxgene application depends on fastobo, and we're running into issues when our users are attempting to install cellxgene on old versions of OS X (e.g. 10.12). That version does not ship with a rust compiler, so our installation fails.

Would you be able to build wheels for older versions of OSX? We believe that should solve the issue we're seeing. The pypi standard appears to be to support versions from 10.9 to present.

Thanks!

cc @mckinsel @maniarathi

@ambrosejcarr ambrosejcarr changed the title Build Pypi wheels from 10.9 Installation fails on older Mac OSX versions Aug 14, 2020
@althonos
Copy link
Member

Hi @ambrosejcarr ,

glad this library is of use to some people, I made it simple and easy-to-use to broaden the audience of ontology consumers 😃

Currently I am building wheels for OSX using the default Travis-CI OSX image, which is Xcode 9.4.1 / macOS 10.13. I'll try to see if it's feasible to use the lowest available version , but I think it only supports macOS 10.11 onward.

Other option I'll try is to have a build script that downloads the Rust compiler locally if not available, so that users without a Rust compiler installed manually can still build from source on their local platform.

@althonos althonos added the bug Something isn't working label Aug 15, 2020
@althonos
Copy link
Member

v0.9.1 now builds the OSX wheels with XCode 7.3, which should increase support of older versions. I also updated the setup script so that, if a wheel cannot be found and compilation from source is attempted, a minimal Rust compiler is used if none is available on the host machine.

@ambrosejcarr
Copy link
Author

ambrosejcarr commented Aug 15, 2020 via email

@mckinsel
Copy link

Just wanted to confirm that this resolved the issue for our user. Thanks very much for the super fast fix @althonos!

@althonos
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants