Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename position_x, position_y, position_z to offsets #499

Closed
kushalkolar opened this issue May 1, 2024 · 1 comment · Fixed by #511
Closed

rename position_x, position_y, position_z to offsets #499

kushalkolar opened this issue May 1, 2024 · 1 comment · Fixed by #511

Comments

@kushalkolar
Copy link
Member

kushalkolar commented May 1, 2024

We should probably rename all the position_<axis> properties to offsets since that's where the WorldObject is placed and does not indicate the buffer data, ex. positions geometry.

realized when doing #498 that this can get confusing

Maybe have:

class Graphic
@offset.setter
def offset(self, offset: tuple[float, float, float]):
  x, y, z = offset
  self.world_object.world.x = x
  ...
@kushalkolar kushalkolar changed the title rename "<axis>_positions" to offsets rename position_x, position_y, position_z to offsets May 1, 2024
@kushalkolar
Copy link
Member Author

to do after graphic features refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant