Skip to content

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater commented Apr 3, 2018

No description provided.

@Arcovion
Copy link
Collaborator

Arcovion commented Apr 3, 2018

Build is failing due to a bug, if you wouldn't mind amending your last commit to:

- rvm: 2.5.1
  before_install:
    # https://github.com/travis-ci/travis-ci/issues/8978#issuecomment-354036443
    - gem update --system

According to travis-ci/travis-ci#8978 (comment) that should fix it!

@bdewater bdewater force-pushed the string-delete-prefix branch from fcae46f to bfc50eb Compare April 3, 2018 15:38
@bdewater
Copy link
Contributor Author

bdewater commented Apr 3, 2018

Thanks @Arcovion !

@Arcovion
Copy link
Collaborator

Arcovion commented Apr 3, 2018

Whoops. I've never actually modified travis.yml, I guess it needs to be done like:

matrix:
  include:
    - rvm: 2.5.1
      before_install:
        # https://github.com/travis-ci/travis-ci/issues/8978#issuecomment-354036443
        - gem update --system

If I'm reading this correctly, it'll run the gem update --system only for 2.5.1; you can then remove the other mention of - 2.5.1 above.

OR we can simply add 2.5.1 to the allowed_failures list for now and remove it once the bug is fixed:

 matrix:
   allow_failures:
     - rvm: 2.5.1

@bdewater bdewater force-pushed the string-delete-prefix branch from bfc50eb to 6571db7 Compare April 3, 2018 16:12
Add Travis workaround for Bundler 1.16.1 and Rubygems 2.7.3
@bdewater bdewater force-pushed the string-delete-prefix branch from 6571db7 to efca7f6 Compare April 3, 2018 16:50
@Arcovion Arcovion merged commit c2b3ce2 into fastruby:master Apr 3, 2018
@bdewater bdewater deleted the string-delete-prefix branch April 3, 2018 17:01
@Arcovion
Copy link
Collaborator

Arcovion commented Apr 3, 2018

Thanks! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants