Skip to content

Conversation

arielj
Copy link

@arielj arielj commented Oct 8, 2020

#18

This PR adds support to use this repo as an NPM/Yarn package so we can use it with Webpacker.

I implemented this so it uses the same source files as the Rails gem so any change in the CSS and JS applies in both cases. I didn't change the Rails gem related code this same repo can be used in both ways.

I had to create these similar-but-different js and scss files because the Rails gems dependencies and the node dependencies uses different names for the assets (bootstrap vs bootstrap-sass, material vs material-design-light) and different organization.

Changes:

  • added index.js as the entry js point
  • added index.scss as the entry scss point
  • added package.json config file for npm with jquery, bootstrap and material-design-lite dependencies
  • updated README with better instructions for both methods

I'm creating a PR in FastRuby.io too that applies this changes.
EDIT: https://github.com/ombulabs/fastruby.io/pull/231

@arielj arielj linked an issue Oct 8, 2020 that may be closed by this pull request
@arielj arielj requested a review from ABizzinotto October 8, 2020 19:19
@arielj arielj changed the title Add yarn package support Add NPM Module support (to use as Yarn package) Oct 8, 2020
Copy link

@cleicar cleicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @arielj

@cleicar
Copy link

cleicar commented Oct 13, 2020

I tested locally and looks good! Thanks.

@cleicar cleicar merged commit 5851fdf into gh-pages Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Webpacker support
2 participants