Clean docs #9
Closed
Clean docs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start the package from a clean slate.
Now developers can run `npm start` to execute the build script.
Use TypeScript to make sure all cases are handled.
This cleans the markdown to be more normal and generates the HTML from that.
The tables were incorrect.
While marked generated the correct content, GFM did not.
It seems like nested lists are a mistake and asterisks should be preserved.
amazingrando
requested changes
Nov 25, 2017
There was a problem hiding this comment.
Thank you for the effort on this. I haven't had the time myself and I appreciate the help. There are a couple of things before I can merge this:
- Indicators for aspects are missing. Currently
<span class="aspect">marks them. I'd like to retain a class to indicate them, with a preference for something like<em class="aspect">. - I don't know the scripting setup that you have. Could you document it further? And is it something that could be run in parallel with the Gulp tasks already in the project? (I'm all for using cool and useful things, I just need an introduction.)
|
So my goal was to largely replace the need for the Gulp work. I do think there are two goals though. One to have clean Markdown, and one to have markdown which works for the FATE SRD site. I did this because you asked me on Twitter but it isn't strictly required. I think you should keep your system if it works. My end goal is actually to try and create a website using Gitbook so I can have local search. |
Nice goal! Sounds useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this tweet, I've updated the transformation script and the contents of the files.