Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: creating the cache folder in parallel #171

Merged
merged 4 commits into from
May 9, 2020
Merged

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented May 9, 2020

Add exist_ok to os.makedirs in case the cache folder is being created in parallel (multiple jobs trying to call makedirs at the same time). Includes a test case with threads and processes to make sure it works.

Fixes #170 and fixes #150

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Should fail on all platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on import when running in parallel Raise exception instead of warning when cache isn't writable
1 participant