Fix build and minor maintenance, show compile errors. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Will give it a test run and merge it tonight! |
|
In the last commit, snaplet-fay shows the compile error at the top of the html file which uses the broken Fay file. I changed the example to demonstrate this. |
|
I am new to github, I just realized that it might have been more appropriate to branch and thus prevent the last commit from being added to this pull request :-) |
|
Yeah, I'm fine with the last change, better than the current error reporting, but the broken.html link gives me a 404. I merged the other changes though so cheers! Open a new ticket if you fix the last commit. |
|
@DanielBruegmann I added the error writing commit as well, but I modified it to use console.error instead of document.write, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The example will not run as-is, because of the fay-jquery requirement. It seems (see devel.cfg) that the original author was using cabal-dev. I used a symbolic link at the location given in devel.cfg to test it.