Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit details not supported as per README #70

Closed
gregwebs opened this issue Oct 18, 2011 · 3 comments
Closed

commit details not supported as per README #70

gregwebs opened this issue Oct 18, 2011 · 3 comments

Comments

@gregwebs
Copy link

repo.commits.first.details
NoMethodError: undefined method `details' for #Octopi::Commit:0x000000017a2af0

@radar
Copy link
Collaborator

radar commented Oct 19, 2011

I can confirm this bug but I haven't gone as far as to investigate why / how it's happening. Would you be able to do that and submit a pull request with any fix that's necessary? Thanks!

@gregwebs
Copy link
Author

The pull would be to delete that example from the README. I thought I would
open this ticket instead in case you wanted to attempt some archaeology if
you had an idea of where this functionality was deleted (assuming it worked
at some point).

On Wed, Oct 19, 2011 at 3:48 AM, Ryan Bigg <
reply@reply.github.com>wrote:

I can confirm this bug but I haven't gone as far as to investigate why /
how it's happening. Would you be able to do that and submit a pull request
with any fix that's necessary? Thanks!

Reply to this email directly or view it on GitHub:
#70 (comment)

@radar radar closed this as completed in dae661c Nov 13, 2011
@radar
Copy link
Collaborator

radar commented Nov 13, 2011

It would be happening because the GitHub API doesn't return details in commit collections any more. Instead, you have to find the individual commit you want the details for and then do a query on that. I've updated the README in effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants