Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localmode Providers (Filestore, Vector DBs) #888

Merged
merged 29 commits into from
Jun 17, 2023
Merged

Localmode Providers (Filestore, Vector DBs) #888

merged 29 commits into from
Jun 17, 2023

Conversation

epps
Copy link
Contributor

@epps epps commented Jun 17, 2023

Description

This PR introduces support for Pinecone and Weaviate as online providers in localmode.

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

sdreyer and others added 29 commits June 16, 2023 13:35
@sdreyer @epps
Abstract Local Filestore provider (#862)
9685016
@epps @anthonylasso
Pinecone as Local Online Provider (#861)
5682142 
Co-authored-by: RedLeader16 <34227093+RedLeader16@users.noreply.github.com>
@sdreyer @epps
Refactored (#864)
c4598a1
@epps
fixes pinecone imports in online store tests and adds stub for table_…
596929d 
…exists to fulfill ABC
@sdreyer @epps
Ability to switch between local providers (#865)
9f378ac
@epps
Fixes PineconeOnlineTable get method (#866)
64a405d
@epps
Weaviate as Local Online Provider (#867)
b5fdb79
@epps
adds weaviate to allowable providers
920e1c2
@epps
fixes gaps in implementation blocking ondemand features w/ vector pro…
01706d3 
…viders in localmode
@aolfat
add vector and dashboard command
b130d8d
@sdreyer
Fix for localmode features (#875)
6590cd3
@sdreyer
Optional Inference store in localmode (#872)
15ae948
@aolfat
fix 1
6faa0c5
@sdreyer
Added error check for inputs list (#878)
0cc86d1
@epps
adds guard clause to progress bar method
5e08e39
@ahmadnazeri @sdreyer
Bugfix: clearing state as well as adding get_state (#876)
6a29f43 
Co-authored-by: sdreyer <sterling@featureform.com>
@ahmadnazeri
Bugfix: changing "default" to "" (#879)
a1363e2
@aolfat @epps
add dashboard command
632607c
@sdreyer
Fixed On Demand Tests (#882)
0a438d4
@ahmadnazeri
Bugfix: Accepting Feature object or (name, variant) tuple for nearest (…
b5f65d6 
…#885)
@aolfat
Task: Fix entitititities so that they're not required
991795b
@sdreyer
Optional Inference store in localmode (#872)
9a086d5
@simba-git @ahmadnazeri
@sdreyer @aolfat
Interactive mode (#880)
019a939 
Co-authored-by: ahmadnazeri <42309296+ahmadnazeri@users.noreply.github.com>
Co-authored-by: sdreyer <sterling@featureform.com>
Co-authored-by: Ali Olfat <ali@featureform.com>
@ahmadnazeri
Bugfix: Give meaningful error when resource not found (#883)
53aa0f1
@simba-git
Fix feature caching (#886)
da6f45e
@aolfat
make entities not required
a69a760 
Revert "make entities not required"

This reverts commit 58122d1.

make on demand work with local
@sdreyer
Fixed tests (#887)
fbff971
@aolfat
delete extra function
b812fb9
@ahmadnazeri @epps
Bugfix: fixing issue with feature serving and training set registrati…
cf374e4 
…on (#881)

Co-authored-by: Erik Eppel <erik@featureform.com>
@epps epps requested a review from aolfat June 17, 2023 04:47
@epps epps had a problem deploying to Integration testing June 17, 2023 04:49 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 17, 2023 04:49 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 17, 2023 04:49 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 17, 2023 04:50 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 17, 2023 04:50 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 17, 2023 04:50 — with GitHub Actions Failure
@epps epps merged commit 54ca760 into main Jun 17, 2023
23 of 42 checks passed
@epps epps deleted the feature/ucb branch June 17, 2023 04:50
@epps epps had a problem deploying to Integration testing June 17, 2023 04:53 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdreyer sdreyer sdreyer approved these changes

@aolfat aolfat Awaiting requested review from aolfat

@ahmadnazeri ahmadnazeri Awaiting requested review from ahmadnazeri

@simba-git simba-git Awaiting requested review from simba-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@epps @sdreyer @aolfat @ahmadnazeri @simba-git