-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add remote follow #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the bot's web presence by integrating a remote follow mechanism. It provides a user-friendly interface for initiating follows from the bot's page, leveraging Fediverse protocols to redirect users to their respective instance's follow pages, thereby improving cross-instance interaction and the bot's reach within the decentralized network.
Highlights
- Remote Follow Feature: Introduces the ability for users to remotely follow the bot directly from its web interface.
- Follow Button and Modal: Adds a 'Follow' button and an interactive modal dialog to the bot's main page, allowing users to input their Fediverse handle.
- New POST /follow Route: Implements a backend endpoint that handles follow requests. This route uses Webfinger to find the appropriate follow URL, prioritizing 'http://ostatus.org/schema/1.0/subscribe' and falling back to 'http://webfinger.net/rel/profile-page'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a remote follow feature, which is a valuable addition. My review focuses on improving the implementation for better maintainability, security, and robustness. I've provided suggestions to refactor the client-side scripting in the new FollowButton
component, harden the new /follow
API endpoint against security vulnerabilities like information leakage, and clean up the code. I also highlighted a potential issue with the fallback logic for constructing follow URLs, which might not be compatible with all Fediverse platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a changelog entry too?
Co-authored-by: Hong Minhee (洪 民憙) <hong@minhee.org>
Co-authored-by: Hong Minhee (洪 民憙) <hong@minhee.org>
7c0ac28
to
82d8246
Compare
ccf974c
to
ced9a13
Compare
Fedify added |
26ec53a
to
b7496c3
Compare
591918f
to
defa2d7
Compare
Summary
Add a remote follow feature.
Related Issue
Closes #10
Changes
POST /follow
route that redirects to the follow page.http://ostatus.org/schema/1.0/subscribe
rel first, and makes follow linksIf it doesn't havehttp://ostatus.org/schema/1.0/subscribe
, Usehttp://webfinger.net/rel/profile-page
instead.Benefits
Users can follow the bot directly on the botkit page.
Checklist
deno task test-all
on your machine?Additional Notes
I checked it on Misskey(https://yuri.garden), Hacker's Pub(which doesn't implement
http://ostatus.org/schema/1.0/subscribe
) and Activity Pub Academy.